[PATCH 0/5] Improve and automate best mix calculations

[Robert Helling]

Rick,

> Am 02.07.2016 um 09:51 schrieb Robert Helling <helling at atdotde.de>:
> 
> thanks a lot. I will look at this more closely once I have a little bit of time (hopefully this weekend).

so here are my comments:

In patch 4/5 you do

+			if (((cyl->gasmix.o2.permille == 0) ? O2_IN_AIR : cyl->gasmix.o2.permille) + cyl->gasmix.he.permille > 1000)

Please do not access the permille’s directly when you are reading. Use get_o2(cal->gasmix) and get_he() instead.

Also, don’t use upper case function names in C code (best_He -> best_he)

Then, there seems to be a problem with rounding (and that might be more what the user expects rather than a mathematical issue): For EAN50 I expect (at least for max_po2=1.6 bar) to get an MOD of 21m. That is what everybody uses. So subsurface should do this as well. In the old MOD calculation we fiddled with the rounding until we did. You should do as well as otherwise users will tell us we cannot do math (even if it’s them).

Then, if we change the depth of the dive, the percentages are not updated. We need the plannerPointsModel send a signal to update the best mixes.

When I set two cylinders to use best mix and then change the max po2, i get an too many gas mixes error.

Finally, there is the question which max pO2 to use. For the „*“ option it should definitely be the bottom one, but for deco mixes I would assume the deco pO2, wouldn’t you?

Best
Robert
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160704/8ca56506/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160704/8ca56506/attachment.sig>