[PATCH] Let cns and otu return ints rather than QStrings so they display correctly when accessed from grantlee template Fixes #1085

Tomaz Canabrava tcanabrava at kde.org
Mon Jul 18 17:21:21 PDT 2016

Actually all of those should be the correct type instead of QString, this
was made because dirk had trouble with qml, but it's incorrect imo.

(tomaz, who has just started to do something he thinks is a nice
improvement to subsurface)

Em 18 de jul de 2016 19:43, "Lubomir I. Ivanov" <neolit123 at gmail.com>

> On 19 July 2016 at 01:08, Tim Wootton <tim at tee-jay.org.uk> wrote:
> > Signed-off-by: Tim Wootton <tim at tee-jay.org.uk>
> > ---
> hello,
> it appears that the commit message has become a part of the commit title.
> other than that ACK.
> given "int" properties (apparently) work in Grantlee the patch is good.
> this small error has slipped in 6f95242f.
> QString(m_dive->maxcns), would threat the m_dive->maxcns as QChar and
> return a string consisting of a single unicode character.
> QString::number(m_dive->maxcns) is the alternative solution.
> lubomir
> --
> _______________________________________________
> subsurface mailing list
> subsurface at subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160718/3eecf1df/attachment.html>

More information about the subsurface mailing list