[PATCH] Correctly determine pre-saturation

Rick Walsh rickmwalsh at gmail.com
Thu Jun 9 16:12:21 PDT 2016


Robert,

On 9 June 2016 at 06:00, Robert Helling <helling at atdotde.de> wrote:

> As pointed out in the user forum, we did not properly take into account
> tissue saturation from previous dives. Turns out, there were two problems:
>
> When determining which dives to consider, we went back in the dive list to
> the first dive in the past of the presently considered dive and then
> further back in time until there was a 48h break. Then we added the
> saturation from there on. In the case of a planned dive (which at the
> planning stage has number -1), this added also dives in the future of the
> to be planned dive. Plus a very long desaturation.
>
> Second, when adding the dive, it then added the surface interval from
> before that dive (rather than the other way around).
>
> Please people (Rick?), could you have a look at the code and check if this
> makes sense. It does so at least in my test case.
>
> Firstly, I've improved a bit but coding and code checking is not my
forte.  Having said that, what you're saying makes sense, and the code is
consistent with that.

Where I'm really struggling is that I haven't come up with a case where I
can see any effect.  Can you outline an example test case?

Rick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160610/6fdb3630/attachment.html>


More information about the subsurface mailing list