[PATCH] Re: Time zones (again)

Linus Torvalds torvalds at linux-foundation.org
Wed Jun 22 16:37:00 PDT 2016


On Wed, Jun 22, 2016 at 4:20 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
>
> OK, this has gone wrong so many times... Linus, Thiago, would you take a
> look at this and give an ACK if you agree that this is reasonable to take?

The patch looks good to me. The only case that isn't obvious is the
use of startTime, but that's apparently the one that actually fixed a
bug, so that makes sense too. The other cases all get rid of the even
uglier use of gettimezoneoffset().

So apart from the extra

  +#include <QDebug>

that Anton pointed out to me, it all looks sane. I didn't *test* it,
but I assume Robert did, and it does look correct as a patch, and I
much prefer the Qt::UTC use over the nasty manual gettimezoneoffset()
games.

              Linus


More information about the subsurface mailing list