[PATCH] Set -std=c++11 flag for g++

[Dirk Hohndel]

> On Jun 23, 2016, at 12:20 PM, Anton Lundin <glance at acc.umu.se> wrote:
> 
> On 22 June, 2016 - Thiago Macieira wrote:
> 
>> On quarta-feira, 22 de junho de 2016 14:59:49 PDT Dirk Hohndel wrote:
>>>> On Jun 22, 2016, at 2:49 PM, Thiago Macieira <thiago at macieira.org> wrote:
>>>> 
>>>> On quarta-feira, 22 de junho de 2016 22:47:23 PDT Anton Lundin wrote:
>>>>> @@ -73,6 +73,7 @@ elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL
>>>>> "AppleClang")
>>>>> 
>>>>>       set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=gnu99 ")
>>>>> 
>>>>> elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
>>>>> 
>>>>>       set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=gnu99")
>>>>> 
>>>>> +       set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
>>>>> elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Intel")
>>>> 
>>>> You want to set it for AppleClang and Intel branches too. Do we support
>>>> building with MSVC at all?
>>> 
>>> No. MinGW, gcc and clang
>> 
>> Ok, so the "Intel" branch above must be on Mac and Linux, which means it takes 
>> the same syntax as GCC and Clang.
>> 
>> If it were on Windows, the syntax would be different, as it tries to be 
>> compatible with MS's compiler.
>> 
> 
> Okay. So we're almost back to what it looked before 4ddf4f6d ?
> 
> 
> Dirk: Are you how okay with c++11 code being allowed in Subsurface or
> at least to allow us to use Qt5.7?

No, careful. I’m grudgingly accepting the fact that we need to compile with
the -std=c++11 flag in order to build against Qt5.7. I am NOT ok with 
including C++11 features in the code. I’d prefer my code to be readable. 
Or to be more explicit - I don’t understand how the new features work, I 
can’t parse the syntax, and if there is one thing that I have learned over 
the past year it’s that I’m on my own when it comes to maintaining this. 
So code that I don’t understand is not welcome.

/D