[PATCH 2/2] gas model: replace Redlich-Kwong with least-square quintic

Linus Torvalds torvalds at linux-foundation.org
Wed Mar 2 15:56:10 PST 2016


On Wed, Mar 2, 2016 at 3:28 PM, Lubomir I. Ivanov <neolit123 at gmail.com> wrote:
>>>
>>>   http://www.baue.org/library/zfactor_table.php
>>
>> i can take a look a these a bit later - e.g. in 30 minutes.
>
> are those pressure values in PSI?

Yes.

> we want them in bars i assume, based on the previous table?

I think it could go both ways.

Converting the tables and polynomials to be based on bar would be the
way we do things internally, and make sense in that way.

But since the public table values are in psi, if we want to keep the
actual *functions* be something that is clearly just a direct
least-squares conversion of the tables we have, I think we could keep
do the polynomial in psi, and just do something like

    double x0 = 1.0;
    double x1 = mbar_to_psi(bar*1000);
    double x2 = x1*x1:
    ...

with a big comment about how the original tables are in psi, and
that's why we're doing polynomials in psi too.

That would perhaps make it easier to explain where the polynomials came from.

I think it's up to you.

              Linus


More information about the subsurface mailing list