[PATCH 3/2] gas model: add polynomials for Z factors of oxygen/nitrogen/helium

Dirk Hohndel dirk at hohndel.org
Wed Mar 2 17:33:18 PST 2016


> On Mar 2, 2016, at 4:55 PM, Linus Torvalds <torvalds at linux-foundation.org> wrote:
> 
> On Wed, Mar 2, 2016 at 4:49 PM, Lubomir I. Ivanov <neolit123 at gmail.com> wrote:
>>> +
>>> +static const double he_coefficients[6] = {
>>> +       +0.9998700261301693,
>>> +       +0.0005452130351730479,
>>> +       +2.7853712233619e-7,
>> 
>> ^ i think i found only this one; should be with a minus sign:
>> 
>> -2.7853712233619e-7*x^2
> 
> Thanks. It got lost in my cut-and-paste edit because:
> 
>> original (helium, quint):
>> ----------------------------
>> y = 0.9998700261301693 + 0.0005452130351730479*x -
>> 2.7853712233619e-7*x^2 + 5.5935404211e-10*x^3 - 1.35114572e-12*x^4 +
>> 2.00476e-15*x^5
> 
> that "-" sign was on the previous line, so when I did a quick
> cut-and-paste I just screwed it up.
> 
> Some third person should double-check that I didn't screw up even more
> somewhere else.
> 
> Dirk, do you want me to re-send with that corrected?


Yes, please - I am looking through all this and am not sure which third patch of a series of two I should be looking for...
And I need to find if there are more patches that I need first? I'm so hip deep in QML stuff to get Subsurface-mobile ready that I'm not paying enough attention here...

/D


More information about the subsurface mailing list