subsurface-ios first patches

Tomaz Canabrava tcanabrava at kde.org
Sat Mar 5 16:51:41 PST 2016


icons.

On Sat, Mar 5, 2016 at 8:19 PM, Tomaz Canabrava <tcanabrava at kde.org> wrote:

> forget this last patch, it breaks deployment for some reason.
>
> On Sat, Mar 5, 2016 at 3:57 PM, Tomaz Canabrava <tcanabrava at kde.org>
> wrote:
>
>> this cleans the CMakeLists file (it reverts to master) and removes some
>> noise on the dumb project for iOS.
>>
>>
>> On Sat, Mar 5, 2016 at 2:01 PM, Tomaz Canabrava <tcanabrava at kde.org>
>> wrote:
>>
>>>
>>>
>>> On Sat, Mar 5, 2016 at 1:50 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
>>>
>>>> Sadly the patches are base64 encoded (typical Mac issue) and I can't
>>>> easily quote them in there.
>>>>
>>>> A few comments:
>>>>
>>>> If you don't use cmake, why patches to the CMakeLists.txt file? That
>>>> seems
>>>> to make no sense (oh, and it's whitespace damaged, too)
>>>> There are also changes to the CMakeLists.txt files in subdirectories.
>>>>
>>>> subsurface-ios/Mainform.ui.qml
>>>> subsurface-ios/main.qml
>>>> subsurface-ios/qml.qrc
>>>>
>>>> What is that used for?
>>>>
>>>
>>> Forgot to clean. Will send a new patch in a bit, sorry for the noise.
>>> The CMake was part of the squash (I forgot about it, but I think I can
>>> easily checkout the CMake from master)
>>>
>>>
>>>>
>>>>
>>>> The include file cleanups could easily be their own patch I think.
>>>>
>>>
>>>
>>>
>>>>
>>>> /D
>>>>
>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160305/a14e6fa5/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Fix-loading-icons-on-ios.patch
Type: application/octet-stream
Size: 815 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160305/a14e6fa5/attachment.obj>


More information about the subsurface mailing list