[PATCH] gas-model: add R compressibility script

Dirk Hohndel dirk at hohndel.org
Sun Mar 13 11:24:10 PDT 2016


On Sun, Mar 13, 2016 at 11:16:00AM -0700, Linus Torvalds wrote:
> On Mar 13, 2016 8:34 AM, "Dirk Hohndel" <dirk at hohndel.org> wrote:
> >
> > This patch doesn't have a commit message and no SOB - was I supposed to
> > apply that?
> 
> It was more of an RFC.
> 
> Do people care? Also, do we want to update the virial coefficients to ones
> that were can reproduce with the R script?
> 
> I can resend the updated patch with the coefficient updates too. But it's
> not like this is important, it's just tying up some loose ends..

So in my mind we have way, way, way over-engineered this. That said, if you
go down the WAY WAY WAY over-engineering rat hole, then gosh darn it FINISH
IT, my friend. It would be a total shame to not have this completely
over-engineered gem be as best over-engineered as we can.

So yes, please send the updated script and update the virial coefficients
and send the optimization to avoid divisions. Because we can. And we
should.

/D


More information about the subsurface mailing list