[PATCH] Build problems

Dirk Hohndel dirk at hohndel.org
Tue Mar 15 07:40:25 PDT 2016


> On Mar 15, 2016, at 3:31 AM, Robert Helling <helling at lmu.de> wrote:
> 
> Hi,
> 
> I am currently enjoying two build problems when using the build.sh script:
> 
> There are errors while building libdivecomputer, it tries also to build examples/dctool_parse.c where in calls of the type VENDOR_MODEL_parser_create a fourth parameter “serial” is missing. But I guess since this is an example this is save to ignore.

It is. But the best is to just remove the useless build of the examples... in the build.sh add "--disable-examples" to the configure call for libdivecomputer

> More serious is in subsurface/scripts/build.sh
> 
> 530c3a38 (Dirk Hohndel             2015-08-16 16:56:56 -0700 142) if [ $PLATFORM = Darwin ] ; then
> 2b1812f2 (Dirk Hohndel             2016-03-03 14:32:23 -0800 143)       if [ -d "~/Qt/5.5" ] ; then
> 2b1812f2 (Dirk Hohndel             2016-03-03 14:32:23 -0800 144)               export CMAKE_PREFIX_PATH=~/Qt/5.5/clang_64/lib/cmake
> 2b1812f2 (Dirk Hohndel             2016-03-03 14:32:23 -0800 145)       elif [ -d "~/Qt/5.6" ] ; then
> 2b1812f2 (Dirk Hohndel             2016-03-03 14:32:23 -0800 146)               export CMAKE_PREFIX_PATH=~/Qt/5.6/clang_64/lib/cmake
> 2b1812f2 (Dirk Hohndel             2016-03-03 14:32:23 -0800 147)       else
> 2b1812f2 (Dirk Hohndel             2016-03-03 14:32:23 -0800 148)               echo "cannot find Qt 5.5 or 5.6 in ~/Qt"
> 2b1812f2 (Dirk Hohndel             2016-03-03 14:32:23 -0800 149)               exit 1
> 2b1812f2 (Dirk Hohndel             2016-03-03 14:32:23 -0800 150)       fi
> 530c3a38 (Dirk Hohndel             2015-08-16 16:56:56 -0700 151) fi
> 
> This does not find ~/Qt/5.5 for me on my Macs.
> 
> I really don’t speak shell but it seems in that in the file test ~ is not interpolated properly. If I replace it by $HOME it works. Here is a patch that does this.

Odd - it worked one of my Macs, but fails on the others. I don't think I installed a different shell but it's possible...

Can you send a second patch to fix the problem above?

/D

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160315/1e0920f2/attachment.html>


More information about the subsurface mailing list