[PATCH] WIP: use kirigami plugin instead of embedding in qrc

Marco Martin notmart at gmail.com
Tue May 17 09:00:46 PDT 2016


On Thu, May 5, 2016 at 5:27 PM, Marco Martin <notmart at gmail.com> wrote:
> Hi all,
> at this point it's being a bit of a problem for me not being able to
> add any C++ part in kirigami, since i cannot do a qml plugin (or
> subsurface would break)
> We included it as qrc resources in the beginning in order to make
> something that worked quickly, but in the end it should be a normal
> plugin on every platform.
> This patch does that for android, it should also make things a bit
> simpler, as removes the burden of maintaining the list of resources
> updated.

Second version of the patch:
it solves a couple of problems it had and now depends from a branch i
have in kirigami:
mart/runtimeTheme
that uses the environment variable QT_QUICK_CONTROLS_STYLE that
Qtquickcontrols are using to select the style.

It doesn't directly affect subsurface yet as look/behavior (in the
futuresome component may get personalized with material/ios look),
except that now this patch would be needed in order for subsurface to
work with upstream  kirigami (that's why i am still waiting in order
to merge)

the patch now uses two cmake options in kirigami that make it not even
search for the optional dependencies, so shouldn't spam with scary
$foo not found messages at configure time anymore

--
Marco Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-the-proper-QML-plugin-for-kirigami.patch
Type: text/x-patch
Size: 9903 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160517/b789e52d/attachment.bin>


More information about the subsurface mailing list