[PATCH] WIP: use kirigami plugin instead of embedding in qrc

[Dirk Hohndel]

On Wed, May 25, 2016 at 07:22:32PM +0200, Marco Martin wrote:
> On Thursday 05 May 2016 17:27:08 Marco Martin wrote:
> > Hi all,
> > at this point it's being a bit of a problem for me not being able to
> > add any C++ part in kirigami, since i cannot do a qml plugin (or
> > subsurface would break)
> > We included it as qrc resources in the beginning in order to make
> > something that worked quickly, but in the end it should be a normal
> > plugin on every platform.
> > This patch does that for android, it should also make things a bit
> > simpler, as removes the burden of maintaining the list of resources
> > updated.
> 
> new patch version:
> this removes the current cmake macros used to generate the apk, as extra -
> cmake-modules now gets pulled in and has an identical functionality, uses that 
> one, that works out of the box without patches to the upstream, it also 
> simplifies a bit the main cmake file as doesn't need some of the explicit if 
> android cases it was using (for instance the difference between add_executable 
> and add_library)
> 
> I would like to merge a branch i'm working on in kirigami next week-ish, that 
> would make this way of including (plugin instead of qrc) pretty much needed , 
> I can delay it a bit more but not much as is a bit of a blocker right now.
> would be cool to know if this can work also for ios

I have not spent any time on Subsurface and don't see that changing in the
next few days. Since clearly no one else is working on Subsurface-mobile,
go ahead, make the change and I'll try to catch up if and when I have time
for Subsurface again.

/D