[PATCH] WIP: use kirigami plugin instead of embedding in qrc

Dirk Hohndel dirk at hohndel.org
Sun May 29 11:25:07 PDT 2016


I continue to be unable to build the plugin for iOS. Fundamentally it boils down to the fact that I can’t figure out how to get anything that links against Qt to build with cmake when building for iOS. Tomaz actually gave up on that for Subsurface-mobile a while ago and decided to add a whole separate qmake file for the iOS build. I’m thinking this may be what we need here as well because I once again spent two hours on getting this fundamentally empty plugin to compile for iOS with absolutely nothing to show for and I find that rather frustrating.

To make matters worse, Tomaz no longer has access to a Mac so he can’t help, either. Which means that right now a Kirigami version that requires the plugin is a non-starter for Subsurface-mobile on iOS. I simply don’t understand how this is supposed to work and nothing that I find online seems to address this combination in a way that I can follow. Not sure what the solution here should be. A qmake file for the kirigami plugin maybe?

/D 


> On May 26, 2016, at 1:41 AM, Marco Martin <notmart at gmail.com> wrote:
> 
> Awesome!
> let me know if you want to give the patch a try and run into hurdles
> 
> On Wednesday 25 May 2016 14:25:18 Tomaz Canabrava wrote:
>> Marco,
>> I don't have the iComputer anymore so I cannot test, but lakademy starts
>> tomorrow and I'll focus solely on subsurface.
>> 
>> Tomaz
>> 
>> Em 25 de mai de 2016 14:22, "Marco Martin" <notmart at gmail.com> escreveu:
>>> On Thursday 05 May 2016 17:27:08 Marco Martin wrote:
>>>> Hi all,
>>>> at this point it's being a bit of a problem for me not being able to
>>>> add any C++ part in kirigami, since i cannot do a qml plugin (or
>>>> subsurface would break)
>>>> We included it as qrc resources in the beginning in order to make
>>>> something that worked quickly, but in the end it should be a normal
>>>> plugin on every platform.
>>>> This patch does that for android, it should also make things a bit
>>>> simpler, as removes the burden of maintaining the list of resources
>>>> updated.
>>> 
>>> new patch version:
>>> this removes the current cmake macros used to generate the apk, as extra -
>>> cmake-modules now gets pulled in and has an identical functionality, uses
>>> that
>>> one, that works out of the box without patches to the upstream, it also
>>> simplifies a bit the main cmake file as doesn't need some of the explicit
>>> if
>>> android cases it was using (for instance the difference between
>>> add_executable
>>> and add_library)
>>> 
>>> I would like to merge a branch i'm working on in kirigami next week-ish,
>>> that
>>> would make this way of including (plugin instead of qrc) pretty much
>>> needed ,
>>> I can delay it a bit more but not much as is a bit of a blocker right now.
>>> would be cool to know if this can work also for ios
>>> 
>>> --
>>> Marco Martin
>>> _______________________________________________
>>> subsurface mailing list
>>> subsurface at subsurface-divelog.org
>>> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
> 
> -- 
> Marco Martin
> _______________________________________________
> subsurface mailing list
> subsurface at subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface



More information about the subsurface mailing list