[PATCH] Provide photos summary on dive list

[Robert Helling]

Willem,

excellent!

> Am 19.11.2016 um 13:44 schrieb Willem Ferguson <willemferguson at zoology.up.ac.za>:
> 
> Please, I need someone to check my coding carefully. I tested it
> quite extensively and have not found any problems. Also, there may
> be places where my code is inefficient.

Looks good from my reading (haven’t tried to build it yet). Just a few comments:

1) You also change the resource name of the location icon. Is that intentional?

2) The picture counting code could probably be simplified a bit by using the FOR_EACH_PICTURE(dive) macro that iterates over the pictures of a dive.

3) Did you draw the icons yourself? If not, are the licenses compatible?

Best
Robert

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20161119/2b50d6f1/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20161119/2b50d6f1/attachment.sig>