updates to Subsurface and libdivecomputer

Linus Torvalds torvalds at linux-foundation.org
Sun Sep 18 11:33:05 PDT 2016


On Sun, Sep 18, 2016 at 7:24 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
> On Sun, Sep 18, 2016 at 08:40:25AM +0200, Anton Lundin wrote:
>> >
>> > I saw the following earlier:
>> > static const hw_ostc_layout_t hw_ostc_layout_frog = {
>> > ...
>> >    32, /* firmware */ /* 32 or 34??? Anton says 32 (34 == battery), Jef says 34 */
>> >
>> > That wasn't me, it was Dirk who said 32. I have no clue about how the hw
>> > frog layout looks.
>
> Since mine is based on docs that I had and Jef actually has a Frog, I'd
> believe him on things like that :-)

So the reason I picked 32 was that we already have offset 34 claimed
by the battery voltage.

So 34 is definitely wrong in one or the other place.

But yes, I mis-attributed the 34. It came from Dirk in commit
0ddec2b50fca ("Support FW Version on OSTC devices").

               Linus


More information about the subsurface mailing list