Subsurface-mobile 1.0.5 (4.5.2.1569) crashes

[Dirk Hohndel]

> On Sep 20, 2016, at 3:03 AM, Henrik Brautaset Aronsen <henrik at synth.no> wrote:
> 
> Steps to reproduce:
> 
> - Clear all Subsurface application storage & caches
> - Start Subsurface and add cloud credentials
> - It starts reading from git, and crashes around 20%

So this is triggered by your data. And the backtrace isn't really telling me much:

09-20 10:56:55.320 27360 27376 F libc    : Fatal signal 11 (SIGSEGV), code 1, fault addr 0x0 in tid 27376 (QtThread)
09-20 10:56:55.383   641   641 D clmlib  : Got activities:0x0000000E
09-20 10:56:55.394   641   641 F DEBUG   : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
09-20 10:56:55.403   641   641 F DEBUG   : UUID: 207e2fc8-d8f2-45d3-b27a-3ecb3289b097
09-20 10:56:55.403   641   641 F DEBUG   : Build fingerprint: 'Sony/E5823/E5823:6.0.1/32.2.A.0.253/2701308494:user/release-keys'
09-20 10:56:55.403   641   641 F DEBUG   : Revision: '0'
09-20 10:56:55.403   641   641 F DEBUG   : ABI: 'arm'
09-20 10:56:55.404   641   641 F DEBUG   : pid: 27360, tid: 27376, name: QtThread  >>> org.subsurfacedivelog.mobile <<<
09-20 10:56:55.404   641   641 F DEBUG   : signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0
09-20 10:56:55.448   641   641 F DEBUG   :     r0 00000000  r1 aca308a0  r2 ffffffff  r3 ffffffff
09-20 10:56:55.449   641   641 F DEBUG   :     r4 aca30168  r5 00000002  r6 ffffffff  r7 00000000
09-20 10:56:55.449   641   641 F DEBUG   :     r8 df7cc8ac  r9 00000000  sl df7cc8bc  fp df7cc8b0
09-20 10:56:55.449   641   641 F DEBUG   :     ip aca308a0  sp df7cc870  lr dfae6833  pc f738c7a4  cpsr a00e0010
09-20 10:56:55.453   641   641 F DEBUG   : 
09-20 10:56:55.453   641   641 F DEBUG   : backtrace:
09-20 10:56:55.453   641   641 F DEBUG   :     #00 pc 000177a4  /system/lib/libc.so (strcmp+48)
09-20 10:56:55.453   641   641 F DEBUG   :     #01 pc 0011882f  /data/app/org.subsurfacedivelog.mobile-2/lib/arm/libsubsurface-mobile.so
09-20 10:56:55.453   641   641 F DEBUG   :     #02 pc 0014cbdd  /data/app/org.subsurfacedivelog.mobile-2/lib/arm/libsubsurface-mobile.so (call_for_each_dc+384)
09-20 10:56:55.453   641   641 F DEBUG   :     #03 pc 00124229  /data/app/org.subsurfacedivelog.mobile-2/lib/arm/libsubsurface-mobile.so
09-20 10:56:55.454   641   641 F DEBUG   :     #04 pc 0012572d  /data/app/org.subsurfacedivelog.mobile-2/lib/arm/libsubsurface-mobile.so
09-20 10:56:55.454   641   641 F DEBUG   :     #05 pc 00124621  /data/app/org.subsurfacedivelog.mobile-2/lib/arm/libsubsurface-mobile.so
09-20 10:56:55.454   641   641 F DEBUG   :     #06 pc 00125f3d  /data/app/org.subsurfacedivelog.mobile-2/lib/arm/libsubsurface-mobile.so
09-20 10:56:55.454   641   641 F DEBUG   :     #07 pc 001d8298  /data/app/org.subsurfacedivelog.mobile-2/lib/arm/libsubsurface-mobile.so

> If I try starting Subsurface again, it crashes after a few seconds (while still on the splash screen).

Likely it's reading the same data from git cache and crashes again.

Ok, looking at the two symbols that I see in the stack trace I am now guessing
that dc_match_serial is crashing for you. Let me see if I can add some protection
to not dereference NULL pointers in there.

/D