more unittests for preferences.

[Dirk Hohndel]

On Wed, Sep 21, 2016 at 09:44:55AM -0700, Dirk Hohndel wrote:
> On Wed, Sep 21, 2016 at 01:23:04PM -0300, Tomaz Canabrava wrote:
> > I'm on my last two days in brazil, things here are *crazy* right now.
> > My next patch will be from munich - probably in a mini-hackaton with
> > robert. :)
> 
> I love patches that add tests that fail :-)
> 
> Now I need to figure out WHY it fails and whether that means the test is
> wrong or it actually identified an issue.

Umm. Tomaz, did you even run your tests?


diff --git a/tests/testpreferences.cpp b/tests/testpreferences.cpp
index 72ea73f88c63..14a40cb81277 100644
--- a/tests/testpreferences.cpp
+++ b/tests/testpreferences.cpp
@@ -61,7 +61,7 @@ void TestPreferences::testPreferences()
 	// Why this is short and not bool?
 	cloud->setSaveUserIdLocal(1);
 	TEST(cloud->saveUserIdLocal(), (short)1);
-	cloud->setSavePasswordLocal(0);
+	cloud->setSaveUserIdLocal(0);
 	TEST(cloud->saveUserIdLocal(), (short)0);
 
 	cloud->setUserId("Tomaz");