Improve MainTab code (#298)

Tomaz Canabrava tcanabrava at kde.org
Tue Apr 11 07:18:37 PDT 2017


On Sat, Apr 8, 2017 at 8:03 PM, Stefan Fuchs <sfuchs at gmx.de> wrote:

> Hi Tomaz, hi all,
>
> Am 07.04.2017 um 11:29 schrieb Tomaz Canabrava:
>
>
>
> On Fri, Apr 7, 2017 at 8:03 AM, Willem Ferguson <
> willemferguson at zoology.up.ac.za> wrote:
>
>> On 07/04/2017 03:45, Dirk Hohndel wrote:
>>
>>> Just a quick heads-up, I just triggered new daily builds of the desktop
>>> version... this includes Tomaz' rewrite of some of the code implementing
>>> the maintab (it moves Info, Extra Info, Statistics, and Photos into
>>> separate files.
>>>
>>> I reviewed the code and did quite a bit of testing. I haven't been able
>>> to
>>> spot anything that got broken. But I'd appreciate if people could take a
>>> close look and make sure I didn't miss anything there...
>>
>>
> Two minor findings up to now, from MXE windows build, Qt 5.7 based:
> - The "Extra Info" tab is the 3rd tab from left now. It should be the last
> tab again.
>

Easy fix, just a drag.


> - This alignment for section "Dives" on "Statistics" tab doesn't look nice:
>

Stramge as I didn't changed the visual, but I'm reworking the statistics,
so stay tuned.


>
>
>
>
> @Dirk: Could you please once again push translation files to Transifex to
> get all this changed stuff translated? This sometimes even reveals some
> more small issues.
>
>
> Best regards
> Stefan
>
> --
>
> Stefan Fuchs
> E-Mail: sfuchs at gmx.de
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170411/2748ac22/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: iboghijkpoohfceo.png
Type: image/png
Size: 6659 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170411/2748ac22/attachment.png>


More information about the subsurface mailing list