[PATCH] MarbleDebug: don't use a class extending QIODevice as a null device

Stefan Fuchs sfuchs at gmx.de
Tue Apr 18 00:08:57 PDT 2017

Hello Lubomir,

Am 17.04.2017 um 23:53 schrieb Lubomir I. Ivanov:
>>> here are the updated Marble files and a patch diff for review.
>>> i can't build Marble to test these changes ATM though.
>> Looks good, so long as "Marble::category" isn't too generic a name.
> ok, i've renamed it to Marable::loggingCategory.
> Stefan, could you please try building and running the attached patch?
> you can toggle the debugging with MarbleDebug::setEnabled(true/false)
> e.g. from the Subsurface source code.
I will try it this morning.
Two remaining questions:
- What is the default state now if we don't set it explicitly? Enabled
true or false?
- Where would be the right place in Subsurface code to put the
MarbleDebug::setEnabled(false) ?

Best regards


Stefan Fuchs
E-Mail: sfuchs at gmx.de <mailto:sfuchs at gmx.de>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170418/edb761a3/attachment.html>

More information about the subsurface mailing list