[PATCH] MarbleDebug: don't use a class extending QIODevice as a null device

[Dirk Hohndel]

On Tue, Apr 18, 2017 at 02:22:52PM +0300, Lubomir I. Ivanov wrote:
> On 18 April 2017 at 10:08, Stefan Fuchs <sfuchs at gmx.de> wrote:
> > Hello Lubomir,
> >
> >
> > Am 17.04.2017 um 23:53 schrieb Lubomir I. Ivanov:
> >
> > here are the updated Marble files and a patch diff for review.
> > i can't build Marble to test these changes ATM though.
> >
> > Looks good, so long as "Marble::category" isn't too generic a name.
> >
> > ok, i've renamed it to Marable::loggingCategory.
> >
> > Stefan, could you please try building and running the attached patch?
> > you can toggle the debugging with MarbleDebug::setEnabled(true/false)
> > e.g. from the Subsurface source code.
> >
> > I will try it this morning.
> > Two remaining questions:
> > - What is the default state now if we don't set it explicitly? Enabled true
> > or false?
> > - Where would be the right place in Subsurface code to put the
> > MarbleDebug::setEnabled(false) ?
> >
> >
> 
> we already do that in desktop-widgets/globe.cpp:
> Marble::MarbleDebug::setEnabled(verbose);

Once this is tested and works as expected, I'd appreciate a pull request.
I'm super busy at work the next couple of days and prone to miss stuff
otherwise.

Thanks

/D