[PATCH] MarbleDebug: don't use a class extending QIODevice as a null device

Stefan Fuchs sfuchs at gmx.de
Thu Apr 20 14:18:27 PDT 2017

Hi Lubomir,

Am 19.04.2017 um 19:37 schrieb Thiago Macieira:
> On quarta-feira, 19 de abril de 2017 03:45:46 PDT Lubomir I. Ivanov wrote:
>> void MarbleDebug::setEnabled(bool enabled)
>> {
>>     QLoggingCategory::setFilterRules(QString("marble.debug=%1").arg(enabled
>> ? "true", "false"));
>> }
>> and likely remove isEnabled() as it's not needed?
> Sounds good, but do we need this setEnabled() in the first place? Is it used 
> anywhere?
I did now a new MXE build based on Qt5.7.1 and marble code as it is
right now in Subsurface-marble branch w/o any new changes like using the
I did some testing and for the moment I can't see the crash/"zombie"
issue any more. So want to say that currently this update seems to be
not that important for a possible upcoming release.

Maybe it would be worthwhile to roll out this QLoggingCategory idea to
the whole project including any logging messages from any component finally.

I keep you updated when I again see a crash like before.

Best regards


Stefan Fuchs
E-Mail: sfuchs at gmx.de <mailto:sfuchs at gmx.de>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170420/2dfb5eac/attachment.html>

More information about the subsurface mailing list