QtLocation map updates

[Lubomir I. Ivanov]

On 2 August 2017 at 01:49, Dirk Hohndel <dirk at hohndel.org> wrote:
>
> Nice. I would love to be able to see if this could be made to work with
> Qt 5.7 (or even better 5.6) - otherwise we are leaving a lot of distributions
> behind. Requiring 5.9 is no problem for Windows and Mac, but for the
> various Linux distros (about 20% or so of our users) it's a no go. Most
> are not even on 5.8 at this point.

i quickly browsed the source and i can't find some of those new 5.9
signals that were breaking the build with Qt 5.7.
maybe you can try building the plugin with the older Qt?

> Lubomir, are you going to send a PR for this? What are the next steps?
>

in my previous email i included a patch which is enough to enable this
on the subsurface side (attaching again).

but...this has to be decided i guess (i.e. how are we going to build
this plugin):

> we have some options with this:
> - include this plugin's source into the Subsurface repository
> it's qmake based so it needs a cmake port (or does it?). this would
> allow us to build it everytime Subsurface is built.
> - fork it as a Subsurface github organization project
> this means that the source needs to be pulled and build using build.sh.
>
> for both cases i'm not sure about the deployment process. right now
> i'm manually copying a DLL inside the Qt-HOME/plugins/geoservices
> folder.
>

lubomir
--
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-mapwidget.qml-use-a-custom-built-googlemaps-plugin.patch
Type: text/x-patch
Size: 1507 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170802/bcb8e6ab/attachment.bin>