QtLocation map updates
Dirk Hohndel
dirk at hohndel.org
Tue Aug 1 17:36:17 PDT 2017
> On Aug 1, 2017, at 5:18 PM, Lubomir I. Ivanov <neolit123 at gmail.com> wrote:
>
> On 2 August 2017 at 03:10, Dirk Hohndel <dirk at hohndel.org> wrote:
>>
>>> On Aug 1, 2017, at 5:09 PM, Lubomir I. Ivanov <neolit123 at gmail.com> wrote:
>>>
>>> probably debugging leftovers.
>>> some of those regex-es in
>>> QGeoTileFetcherGooglemaps::_googleVersionCompleted() are kind of scary
>>> but the mentioned variables are unused like you have pointed out.
>>>
>>> the important part happens in:
>>> QGeoTileFetcherGooglemaps::_tryCorrectGoogleVersions()
>>>
>>> e.g.:
>>> QString url = "http://maps.google.com/maps/api/js?v=3.2&sensor=false";
>>>
>>> which is fixing the version to 3.2.
>>
>> Since the project seems to be actively maintained, would it make sense
>> to send them pull requests to clean things up?
>>
>
> we could do that, but also, it's a single guy so he might decide to
> abandon the project at any point in time (e.g. tomorrow), so forking
> that repository is imminent IMHO.
We should certainly fork this so we have it available. But in my
experience showing interest in a project, providing pull requests
(and yes, sometimes issues) will increase the likelihood that the
project stays alive.
//D
More information about the subsurface
mailing list