Subsurface-mobile crash on deleting dive from dive list

[Dirk Hohndel]

On Thu, Aug 10, 2017 at 06:51:57PM +1000, Rick Walsh wrote:
> >> >
> >> > This is not a new bug, and has been reported before, but I think it's
> >> one that should be eliminated before the next release.  When deleting a
> >> dive from the dive list (select the dive from the list but hold down until
> >> the trash icon appears, then select the trash icon), the app will crash...
> >> sometimes.  But sometimes it works.
> >>
> >> I have spent many hours on this. Yes, we either need to fix this or
> >> remove the feature.
> >>
> > I agree, I meant to say we should remove the feature if we can't fix it.
> >
> >> This won't prevent another beta (it's not a regression, it's broken in
> >> the current beta), but it will prevent the actual release of 2.0.
> >
> >
> 
> > My suspicion is that somehow our different models get out of sync. But
> >> it's really, really hard to debug this :-(
> >>
> >
> > Indeed it is
> >
> Unfortunately I don't understand how or why the models get out of sync, but
> I just made a one-line pull request. And this time, in my testing at least,
> the bug has been fixed.  Please test more.

Cool. I just pulled a couple of the PRs and have a new APK up - it would
be great if people could test if this indeed fixes that annoying crash.
Thanks for your persistence, Rick.

I also have new Windows / OBS / Launchpad builds happening. I am not sure
if the Linux builds are currently working correctly (with the map widget
changes - I ran out of time testing those before heaing on family
vacation), but the Windows one should be OK (and that one includes a few
of the other bug fixes that were posted)

/D