Wrong grouping of dives

Linus Torvalds torvalds at linux-foundation.org
Sat Aug 19 14:56:44 PDT 2017


On Sat, Aug 19, 2017 at 11:18 AM, Alexander Maier <maieralex at me.com> wrote:
>
> I have tested subsurface and now I have one problem. If I sort my
> dives by number there is a grouping of the dives by dive sites. This
> grouping is wrong. The same grouping is also on my iOS App
> surface-mobile.

It's rally not a "group by dive site" thing at all, it's a "group by trip".

It just makes the trip name be the first divesite of the trip by
default, but you can edit the trip information itself, and make it not
be the dive site, but a more descriptive name for whatever dive trip
you were on.

And the automatic grouping by trip is really very much just a
heuristic: it just says "if your dives are within two days of each
other, we assume it's all the same trip". And if it turns out that you
really had two or more local trips that were just close to each other
(and want them to be grouped as such), then you just edit the trip
information by hand.

Editing the trip information is trivial: just select the dives you
want (the usual way with "shift" or "control" to add a range of dives
or just a single dive), and then use the right mouse button to get the
dive list menu, and do "Create new trip above".

Or if you want to use the trip feature just for *actual* trips, and
you don't want to put local dives into trips at all, you do exactly
the same thing, except you pick "remove dives from trip" instead. A
dive doesn't _have_ to be in a trip, it's just a default thing that
subsurface does when you check that "autogroup dives" thing.

The trip grouping is very convenient (and really does the right thing
almost all the time) for divers like me who mainly dive on trips to
far-away warm water. For somebody who mostly dives locally, and
doesn't really take "trips" to diving, it might be more convenient to
just not auto-group by default at all.

So even if you disable the auto-trip feature, you can still *manually*
create trips if you want to.

So the auto-grouping really is purely a convenience feature, and the
"within two days" (maybe it's three days - I forget) really is just
what is largely the right choice for people who tend to fly to their
diving.

Also, note that even if you *do* use trips, you can always sort by
actual date get the non-trip "just give me the dives in time format".
The trip information is only shown for the default "sort by dive
number" case.

            Linus


More information about the subsurface mailing list