removing Marble traces from the Subsurface tree

Lubomir I. Ivanov neolit123 at gmail.com
Sun Aug 27 11:17:33 PDT 2017


On 27 August 2017 at 01:14, Dirk Hohndel <dirk at hohndel.org> wrote:
> On Sat, Aug 26, 2017 at 04:52:49PM +0300, Lubomir I. Ivanov wrote:
>> 1)
>> here is a PR with a small change in the googlemaps plugin's qmake to
>> allow using headers from relative paths:
>> https://github.com/vladest/googlemaps/pull/15
>>
>> 2)
>> attached is my updated script to fetch the QtLocation and
>> QtPositioning private headers from the Qt repository.
>> if someone has the time you can integrated that into our build.sh.
>>
>> one potential problem here is that i don't know how to place the
>> headers in install_root and tell the qmake of the googlemaps plugin to
>> use install_root in a non-disruptive way (i.e. only we care about
>> install_root). instead the solution might be to simply copy the header
>> folders inside the googlemaps plugin folder it will work.
>>
>> NOTE: both these changes require qmake5.
>> need to leave in a minute and will be back on sunday afternoon (EET).
>
> I took your script, made a few modifications (I really wanted those
> include files under our install-root), included it in the build script,
> and pushed all of that to master.
>
> vladest just merged your PR, so now this compiles and runs with working
> maps on Ubuntu 16.10 (that's what I had a VM of); I also tested ArchLinux
> and Fedora 25. I'd love to hear if this works on other Linux flavors that
> people care about.

oops, i've missed this email, started working on the changes myself
and created a PR.
just saw the email and canceled the PR, which really was less complete
of an implementation.

thanks
lubomir
--


More information about the subsurface mailing list