Warnings (was: Subsurface libdivecomputer branch merged with upstream..)

Dirk Hohndel dirk at hohndel.org
Fri Dec 15 08:45:41 PST 2017

Hi Berthold,

Linus tends to have strong feelings about warnings, about patches that silence warnings,
and about data type changes to silence warnings.

I'll let him comment on "-Wall" and on the patch below.


> On Dec 15, 2017, at 1:24 AM, Berthold Stoeger <bstoeger at mail.tuwien.ac.at> wrote:
> On Mittwoch, 13. Dezember 2017 23:34:32 CET Dirk Hohndel wrote:
>>> On Dec 13, 2017, at 11:31 AM, Berthold Stoeger
>>> <bstoeger at mail.tuwien.ac.at> wrote:> 
>>> PS: compilation of libdivecomputer produces tons of warnings. :-o
>> Yes, Jef cranked up the warning level quite a bit.
>> I actually removed two of them (-Wextra and -Wpedantic) to keep things at
>> least somewhat manageable, but it is noisy.
> Speaking of warnings: how about compiling subsurface with -Wall as a default? 
> At least on gcc it's pretty clean and only seems to address real issues.
> Concerning the float warning, I have a patch that turns all float calculations 
> into double calculations sitting around for a few weeks. I think float is like 
> short: only to be used in very specific circumstances. But I'll let the pros 
> decide.
> Berthold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Unify-float-calulations-use-double.patch
Type: text/x-patch
Size: 8885 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20171215/9af9a510/attachment-0001.bin>
-------------- next part --------------

More information about the subsurface mailing list