Warnings (was: Subsurface libdivecomputer branch merged with upstream..)
Dirk Hohndel
dirk at hohndel.org
Sun Dec 17 08:42:41 PST 2017
> On Dec 17, 2017, at 4:38 AM, Berthold Stoeger <bstoeger at mail.tuwien.ac.at> wrote:
> This is of course all correct, but none of the proposed changes are anywhere
> close to in a tight loop. In some cases it's only a local variable which is
> not even spilled to RAM.
>
> I tried to look at the assembler output and the first thing I noted is that we
> don't compile with -O2? Is that on purpose?
>
> Anyway, with -O3, the first case in plannernotes.h produces better code without
> casting to float. You could of course get the same result by replacing 1000.0
> with 1000.0f, but this seems rather obscure.
>
> I removed two cases concerning binary representation from the patch and made a
> PR. Perhaps we get Linus to have a look at it.
I had already applied the patch locally but ran out of time before pushing. Happy
to look at your PR instead. Not sure I'll have a lot of time today, either, but I'll try.
/D
More information about the subsurface
mailing list