4.7.6

[Cristian Ionescu-Idbohrn]

On Sun, 24 Dec 2017, Dirk Hohndel wrote:
> > On Dec 24, 2017, at 12:11 PM, Cristian Ionescu-Idbohrn <cristian.ionescu-idbohrn at axis.com> wrote:
> > 
> > On Sun, 24 Dec 2017, Dirk Hohndel wrote:
> >> 
> >> There are a couple of small issues with 4.7.5 (QtQuick version 
> >> causes issues on old Linux distros with Qt 5.5, the annoying warning 
> >> about the "m'" in the git storage) and of course we have a couple 
> >> cool new features like the picture zoom levels and semi-closed 
> >> rebreather support for the OSTC...
> >> 
> >> Is there anything I should wait for? Anything that we broke since 
> >> 4.7.5 and haven't fixed?
> > 
> > Didn't check what goes in there, but master fails to build for be, 
> > since a few days back:
> > 
> > [ 46%] Built target subsurface_corelib_autogen
> > [ 47%] Building C object 
> > core/CMakeFiles/subsurface_corelib.dir/libdivecomputer.c.o
> > .../subsurface/core/libdivecomputer.c: In function 
> > 'libdc_header_parser':
> > .../subsurface/core/libdivecomputer.c:738:8: error: 
> > 'DC_DIVEMODE_CCR' undeclared (first use in this function); did you 
> > mean 'DC_DIVEMODE_CC'?
> >   case DC_DIVEMODE_CCR:  /* Closed circuit rebreather*/
> >        ^~~~~~~~~~~~~~~
> >        DC_DIVEMODE_CC
> > .../subsurface/core/libdivecomputer.c:738:8: note: 
> > each undeclared identifier is reported only once for each function it 
> > appears in
> > .../subsurface/core/libdivecomputer.c:741:8: error: 
> > 'DC_DIVEMODE_SCR' undeclared (first use in this function); did you 
> > mean 'DC_DIVEMODE_CCR'?
> >   case DC_DIVEMODE_SCR:  /* Semi-closed circuit rebreather */
> >        ^~~~~~~~~~~~~~~
> >        DC_DIVEMODE_CCR
> > .../subsurface/core/libdivecomputer.c:730:3: warning: 
> > enumeration value 'DC_DIVEMODE_CC' not handled in switch [-Wswitch]
> >   switch(divemode) {
> >   ^~~~~~
> > core/CMakeFiles/subsurface_corelib.dir/build.make:374: recipe for 
> > target 'core/CMakeFiles/subsurface_corelib.dir/libdivecomputer.c.o' 
> > failed
> > make[2]: *** 
> > [core/CMakeFiles/subsurface_corelib.dir/libdivecomputer.c.o] Error 1
> > CMakeFiles/Makefile2:473: recipe for target 
> > 'core/CMakeFiles/subsurface_corelib.dir/all' failed
> > make[1]: *** [core/CMakeFiles/subsurface_corelib.dir/all] Error 2
> > Makefile:129: recipe for target 'all' failed
> > 
> > and I don't know what I'm missing :(
> 
> 
> You're not building against the current libdivecomputer.

I'd have expected build.sh would pull current libdivecomputer, which 
it seems to do:

[Subsurface-branch %=]> git fetch
[Subsurface-branch %=]> git pull 
Already up to date.
[Subsurface-branch %=]> git describe 
v4.6.4-131-gc0f025b
[Subsurface-branch %=]> git status 
On branch Subsurface-branch
Your branch is up to date with 'origin/Subsurface-branch'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)

        build/

nothing added to commit but untracked files present (use "git add" to 
track)

Still, no joy :(


Cheers,

-- 
Cristian