[PATCH] Detect location of `ldconfig' before use

Cristian Ionescu-Idbohrn cristian.ionescu-idbohrn at axis.com
Sun Feb 5 06:21:26 PST 2017


On Sun, 5 Feb 2017, Robert C. Helling wrote:
> > Am 05.02.2017 um 12:53 schrieb Cristian Ionescu-Idbohrn <cristian.ionescu-idbohrn at axis.com>:
> > 
> > That's the reason shell option '-e' (errexit) was introduced.
> 
> That option had been introduced before and then later been removed 
> again. The build on mac throws warnings about certain Qt things that 
> one should do (but which are not necessarily) and with -e that is 
> the end of the build.
> 
> So please don't. 

I have an idea ;)

Why not error handle those the code that produces those "warnings" (as 
you call them) on that particular architecture, instead of 
ignoring/hiding the errors (exit status failure) for everyone?  That 
kind of thing can bite you later in various ways, leading to bug 
reports saying "I tried that but it doesn't work :/  The build script 
exits with success, but...  Could you fix it for me?  I can't tell you 
where to start looking :(".

'errexit' was not invented to punish people, but to help coding robust 
scripts.  In my experience, error handling is one of the most 
neglected areas.


Cheers,

-- 
Cristian


More information about the subsurface mailing list