Subsurface deco calculations

[Robert Helling]

> On 08 Feb 2017, at 21:44, Linus Torvalds <torvalds at linux-foundation.org> wrote:
> 
> On Wed, Feb 8, 2017 at 12:36 PM, Robert Helling <helling at atdotde.de> wrote:
>> 
>> from what I see, in the matching you only look at the gas percentages but
>> not at the content (start/end pressures and sizes).
> 
> Correct. There's a
> 
>    /* FIXME! Should we check sizes too? */
> 
> where such checks would go, but sizes are sometimes definitely
> unreliable (ie divecomputer downloads giving bogus info etc), so I
> left it open.
> 
>> In Willem’s case that
>> wouldn’t be good enough. I would say, don’t merge cylinders if both have
>> start and end pressures and they differ. And in merging don’t overwrite
>> valid start/end pressures by zero.
> 
> Is there a test-case for this somewhere? I was hoping the "same gasmix
> in same order" would take care of it,  but..
> 
> But yes, we could try to at least save gas pressures. Again, a
> test-case for this would be lovely, just so that I don't do it
> blindly.
> 
>              Linus

Hi,

-------------- next part --------------
A non-text attachment was scrubbed...
Name: Before_merge.xml
Type: application/xml
Size: 100652 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170208/f7526666/attachment-0001.xml>
-------------- next part --------------


here  is the example that Willem sent a few days ago. Here, the gases differ both by o2 percentage and by start/end pressures but I would argue they should not end up with the same cylinder even if the o2 percentage would be the same.

Best
Robert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170208/f7526666/attachment-0001.sig>