Subsurface deco calculations

[Robert Helling]

Hi,

> On 09 Feb 2017, at 00:09, Linus Torvalds <torvalds at linux-foundation.org> wrote:
> 
> I've pushed out my branch and made a github pull request for people. I
> still encourage people to take a look, but it seems to handle both
> Miika's and Willem's cases just fine, and it passes my "looks sane"
> test.

one thing I forgot to mention yesterday was that with this more liberal cylinder merging which is likely to make the user end up with more cylinders that in the end represent the same cylinder (just with different information about it) is likely to screw up the statistics logic: There we consider gas use from any of the cylinders and if one dive computer has a cylinder with EAN36 say and the other computer says (knows) it only has EAN35 we count the gas use twice. Maybe, for the statistics we should only count the gas that was used by the first computer (i.e. that has gas change events in the first computer and lacking this has cylinder id 0).

What do you think?

Best
Robert
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170209/9e7b5249/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170209/9e7b5249/attachment.sig>