Subsurface minimum gas calculation - First version for review

Robert Helling helling at atdotde.de
Fri Feb 17 08:56:20 PST 2017


Stefan,

> On 17.02.2017, at 17:47, Dirk Hohndel <dirk at hohndel.org> wrote:
> 
>> 
>> On Feb 17, 2017, at 3:57 AM, Stefan Fuchs <sfuchs at gmx.de <mailto:sfuchs at gmx.de>> wrote:
>> 
>> Hi All,
>> 
>> 
>> Am 15.02.2017 um 21:27 schrieb Stefan Fuchs:
>>>> 
>>>> Joachim (R.) and I finished our first basic version of the minimum gas calculation for the planner.
>>>> We are now looking for testing and feedback :-)
>>>> 
>>>> More details below...
>>>> Link to initial idea and discussion:
>>>> https://github.com/Subsurface-divelog/subsurface/issues/188 <https://github.com/Subsurface-divelog/subsurface/issues/188>
>>>> Link to feature branch on Github:
>>>> https://github.com/sfuchs79/subsurface/tree/feature_minimum_gas <https://github.com/sfuchs79/subsurface/tree/feature_minimum_gas>
>>>> 
>>> For this and all the other comments from Robert I hope I understood everything and there is nothing to discuss. Updated version will come soon.
>>> A very important hint came from Robert about why we add the two new variables to struct diveplan. This was clearly a mistake is not needed. I will remove it.
>> 
>> Updated version available. I'm not 100% sure if I catched everything. I did some more testing and found no more real bugs.
>> 
>> Documentation is still missing. Will be able to do this next week.
>> 
>> Again the one question about putting a warning icon into the profile: It would be great if there is anyone who could guide me how to do this.
> 
> Look at the DiveEventItem usage in the profilewidget2.cpp - you need to tell it which axes its coordinates are relative to (timeAxis and profileYAxis most likely, and you need to give it an event to display. And then you add it to the scene.


maybe, you should actually create an event (which would then automatically be added to the profile), SAMPLE_EVENT_AIRTIME sounds like the right option.

Best
Robert

--
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics
                      Scientific Coordinator
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik
                      Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339
                      http://www.atdotde.de

Enhance your privacy, use cryptography! My PGP keys have fingerprints
A9D1 A01D 13A5 31FA 6515  BB44 0820 367C 36BC 0C1D    and
DCED 37B6 251C 7861 270D  5613 95C7 9D32 9A8D 9B8F





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170217/2dc0a0eb/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170217/2dc0a0eb/attachment-0001.sig>


More information about the subsurface mailing list