problem in our file format

[Robert Helling]

> On 22.02.2017, at 11:03, Dirk Hohndel <dirk at hohndel.org> wrote:
> 
> Yeah OOPS, that description goes into the XML file / git storage. So we
> now have a localized string that has "meaning". Because of that we can't
> simply say "oh, we are merging two dives, they have the same cylinder, but
> in one of the two dives we have a 'better' description" (let's say one
> gets you the correct "AL80", the other one has the same volume / working
> pressure, but description "unknown”).

In principle you could compare to the translation of “unknown” as well…
But this is ugly and might cause strange behavior when people change their localization in the middle.

> 
> But because I foolishly decided to translate that string, we no longer can
> do that...
> 
> Is this worth fixing? I.e., store "unknown" in this case as literal and
> instead translate "unknown" when it is encountered in the UI as tank
> description? I think that's the right thing to do, but I figured it was
> worth asking for feedback.


I guess that is the way to go. And make sure (at least for a while) that when parsing such a file retranslate the translated version of unknown back to unknown so we git rid of these in old logs.

Best
Robert

--
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics
                      Scientific Coordinator
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik
                      Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339
                      http://www.atdotde.de

Enhance your privacy, use cryptography! My PGP keys have fingerprints
A9D1 A01D 13A5 31FA 6515  BB44 0820 367C 36BC 0C1D    and
DCED 37B6 251C 7861 270D  5613 95C7 9D32 9A8D 9B8F





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170222/8d3ef565/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170222/8d3ef565/attachment-0001.sig>