Subsurface minimum gas calculation - First version for review

Rick Walsh rickmwalsh at
Wed Feb 22 12:57:57 PST 2017

On 22 February 2017 at 20:14, Stefan Fuchs <sfuchs at> wrote:

> Hallo Dirk, hallo Joachim,
> Am 22.02.2017 um 00:10 schrieb Dirk Hohndel:
> For the moment I have to stop here because I will be on holiday for a week
> soon and this part for sure will need approximately 1-3 years development
> time on my side ;-)
> What do you think about the part of the minim gas calculation we created
> up to now?
> Is it already time to do a pull request to maybe have some deeper testing
> or do we need to continue testing and review internally?
> I'd like to ask that anything that is submitted for master has had some
> review and testing, comes with an automated test or two and most
> importantly tries to be as non-invasive as possible.
> Automated tests? Well, that means another +2 years of development time on
> my side ;-)
> Just kidding... I will try to learn how this works after my holiday. BTW:
> Joachim, could you have a look into this as well?

Stefan, Joachim,

tests/testplan.cpp is where the existing planner tests are.  This would be
a good starting place as it shows how to set up preferences and define a
dive to test.  In fact, you could probably modify the existing dive tests
to add a test for expected minimum gas results.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the subsurface mailing list