[PATCH 2/2] Remove unused function SettingsObjectWrapper::sync()

Rick Walsh rickmwalsh at gmail.com
Sat Jan 7 12:42:27 PST 2017


On 8 January 2017 at 02:10, Dirk Hohndel <dirk at hohndel.org> wrote:

> Actually, I found where sync() is used. In the tests. So NAK from here
>
>
> That was silly of me.  I was even looking in testpreferences.cpp to work
out how the setSomething() functions were used.  I'll wear the dunce's cap
for not testing the tests.

If sync() is only used in the tests, would it be better if the function
were in testpreferences.cpp instead?

Thanks for taking the first patch, which is the one that actually fixes a
bug.

Rick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170108/91ddb893/attachment.html>


More information about the subsurface mailing list