Windows build successful - Findings

[Stefan Fuchs]

Am 28.01.2017 um 22:33 schrieb Dirk Hohndel:
>>>
>>>> *Now for the moment I still have one minor issue left:*
>>>> - A few standard terms like "Cancel / Abbrechen", "Save /
>>>> Speichern" on buttons are not translated into German in my build.
>>>> In the official 4.6 they are translated.
>>>> What's missing here on my side? S.th <http://s.th/>. MXE/Qt related?
>>>
>>> This sounds like the Qt translations aren't installed correctly. If
>>> you compare the content of the translations directory between your
>>> installer and the one I publish... are any files missing or vastly
>>> different in size? I vaguely remember that I ran into this issue at
>>> some point...
>>>
>>> Of course, when I looked on my build server qt_de.qml does seem
>>> suspiciously small, so I wonder if the latest Subsurface installer
>>> for Windows actually gets the translation of system messages right...
>>
>> Nope, it does not. If you go to "Einstellungen" when running
>> Subsurface in German, you will see "Save" "Cancel" and "Apply" :-(
>>
>> Now I need to remember how I fixed this the last time I ran into that :-(
>
> And to continue this conversation with myself (the only one,
> apparently, who likes to listen to me / talk to me)...
>
> We used to do this in our qmake file. Yikes that's been broken for a
> long time and apparently no one ever complained. I, of course, run
> Subsurface in English, so this doesn't bother me - but clearly none of
> the folks using Subsurface in German over the past two years have
> noticed... :-)
>
> We should either add this to the cmake magic, or maybe just manually
> copy the missing files in the mxe-based-build.sh
>
> The subsurface.pro copied these additional files - not sure if that's
> all that's missing today (this was Qt 5.3, based on the comments)
>
> -       qtbase_de.qm \
> -       qt_fi.qm \
> -       qtbase_fi.qm \
> -       qtbase_hu.qm \
> -       qtbase_ru.qm \
> -       qtbase_sk.qm
>
I played with the different files and it seems that "qtxmlpatterns_" is
needed. The last file I expected when looking at the name...
So maybe really better add almost all those files.

I really like to contribute s.th. This is why I spent all the time on
this currently. But I still need some help e.g. with git and github and
first of all read some documentation.
E.g. I messed up my repository on github already by pushing things there
to master which never should go into a pull request to you ;-(
I maybe better start this from scratch and next time read the manual
before starting.

MfG
Stefan


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170128/5b5e6b89/attachment-0001.html>