Beginnings of a mobile planner

[Rick Walsh]

On 14 Jul. 2017 03:47, "Martin de Weger" <martin at reef-it.nl> wrote:

Hi Rick,

Could you please mail me the 5 line instructions? I’m trying to make myself
useful and try to work on things, but I have “issues” with GitHub. :/


Hi Martin,

Here's Dirk's email from when I emailed my last patch.

On 22 Jun. 2017 21:48, "Dirk Hohndel" <dirk at hohndel.org> wrote:

Obviously correct patch. Duh.

> On Jun 22, 2017, at 2:22 AM, Rick Walsh <rickmwalsh at gmail.com> wrote:
>
> Signed-off-by: Rick Walsh <rickmwalsh at gmail.com>
> ---
> I will try to work out how to do GitHub pull requests

I'm happy to take things like this as patches, Rick.

But creating a pull request is really easy.
You need a GitHub account.
Fork the Subsurface-divelog/subsurface repo
Create a local branch
git checkout -b forDirk
add the commit there
git push https://github.com/<yourGitHubID>/subsurface forDirk
enter your login and password
now on the website navigate to that branch
there will be a button to create the pull request.





On 13 jul. 2017 13:35 +0200, Tomaz Canabrava <tcanabrava at kde.org>, wrote:

On it


Thank you very much Tomaz.

Cheers,

Rick



On Thu 13. Jul 2017 at 13:35, Tomaz Canabrava <tcanabrava at kde.org> wrote:

>
>
> On Thu 13. Jul 2017 at 13:14, Rick Walsh <rickmwalsh at gmail.com> wrote:
>
>> Hi,
>>
>> With one of the greatest features of Subsurface-mobile, downloading from
>> dive computers becoming a reality (and way beyond my knowledge to be
>> contributing to the code there), and some spare time in airports and hotel
>> rooms thanks to working away from home for a few weeks, I thought I'd try
>> to tackle that other Subsurface feature that's missing from the app.  While
>> plenty of users will ignore it, it is far beyond a toy or curiosity, and a
>> powerful mobile dive planner will be very handy to those that want it.
>>
>> How hard could it be? I asked myself.  The UI side of things is tedious
>> but actually not too difficult.  I won't say it's a work of art, but it
>> should be functional.  But now I'm stuck - I haven't managed to work out
>> how to integrate the Qt models, CylindersModel and DivePlannerPointsModel,
>> with the QML side of things, and I don't know how to call the code that
>> does the actual planning.  I understand what the UI does, and I understand
>> the C code, but the magic in between is lost on me.
>>
>> I pushed my work to GitHub (thanks Dirk, your 5 line instructions a month
>> or so ago was far more helpful than any guide I found online), but this
>> should not go into Master just before a major Subsurface-mobile release.
>>
>> https://github.com/RickMWalsh/subsurface/tree/mobilePlanner
>>
>> So, would someone with Qt knowledge be able to take a look and either (a)
>> let me know how to link the QML and Qt, or (b) do it themselves?  It builds
>> and runs just fine on the desktop, so no need to create an apk just to test
>> it.
>>
>> Thanks,
>>
>> Rick
>> _______________________________________________
>> subsurface mailing list
>> subsurface at subsurface-divelog.org
>> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>>
> _______________________________________________
subsurface mailing list
subsurface at subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170714/6f2f9ffe/attachment.html>