[PATCH 1/2] QML UI: use Material default switches

[Joakim Bygdell]

On 23 July 2017 at 09:18, Rick Walsh <rickmwalsh at gmail.com> wrote:

>
>
> On 23 July 2017 at 18:57, Rick Walsh <rickmwalsh at gmail.com> wrote:
>
>>
>>
>> On 23 July 2017 at 17:26, Joakim Bygdell <j.bygdell at gmail.com> wrote:
>>
>>>
>>>
>>> In which way does a white button on a white background look better??
>>>
>>> There is no styling what so ever on that button meaning that it will be
>>> white
>>> even when the dark theme is in use.
>>>
>>> White on a light background is what the Material guidelines say should
>> be used for an off switch.
>> https://material.io/guidelines/components/selection-
>> controls.html#selection-controls-switch
>>
>> The switch colouring is styled according to the Material accent colour,
>> which we set in main.qml.  I agree it looks pretty poor with the dark
>> theme, but if we set the accent colour to have the same sat and val (but
>> blue hue) as the Material default, then it looks much better.  Please try
>> the attached patch and see what you think.
>>
> So you don't have to apply and test it yourself, here is what I mean.  I
> think the dark theme is better with the lighter accent colour.
>
> Yes it is.
On the other hand the dark theme is highly beta, in order to get it to look
good there are multiple changes that needs to be made.
For the 2.0 release maybe we can disable the dark theme and not waste any
time on getting the colors right, also there are Kirigami issues
related to the dark theme that I have not been able to fix yet.
There are other parts that are more important to fix, like when the app
starts, the top menu is light blue,
almost turquoise in color before it switches to the theme color.


-- 
Jocke
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170723/d9baca54/attachment.html>