[PATCH 1/2] QML UI: use Material default switches

[Joakim Bygdell]

On 23 July 2017 at 16:12, Dirk Hohndel <dirk at hohndel.org> wrote:

>
> On Jul 23, 2017, at 12:18 AM, Rick Walsh <rickmwalsh at gmail.com> wrote:
>
>
>
> On 23 July 2017 at 18:57, Rick Walsh <rickmwalsh at gmail.com> wrote:
>
>>
>>
>> On 23 July 2017 at 17:26, Joakim Bygdell <j.bygdell at gmail.com> wrote:
>>
>>>
>>>
>>> In which way does a white button on a white background look better??
>>>
>>> There is no styling what so ever on that button meaning that it will be
>>> white
>>> even when the dark theme is in use.
>>>
>>> White on a light background is what the Material guidelines say should
>> be used for an off switch.
>> https://material.io/guidelines/components/selection-
>> controls.html#selection-controls-switch
>>
>> The switch colouring is styled according to the Material accent colour,
>> which we set in main.qml.  I agree it looks pretty poor with the dark
>> theme, but if we set the accent colour to have the same sat and val (but
>> blue hue) as the Material default, then it looks much better.  Please try
>> the attached patch and see what you think.
>>
> So you don't have to apply and test it yourself, here is what I mean.  I
> think the dark theme is better with the lighter accent colour.
>
>
> I like the colored switches much better.
> But I think they need to be more similar in size to the check boxes, or
> maybe the check boxes need to be more similar in size to them?
> Either way, they should be consistent.
>
> /D
>
>
Look at my latest PR, the checkboxes are gone.


-- 
Jocke
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170723/bff5c778/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Dark.png
Type: image/png
Size: 24676 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170723/bff5c778/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Pink.png
Type: image/png
Size: 28448 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170723/bff5c778/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Blue.png
Type: image/png
Size: 28062 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170723/bff5c778/attachment-0005.png>