[PATCH] Try to sanely download multiple concurrent cylinder pressures

Linus Torvalds torvalds at linux-foundation.org
Tue Jul 25 12:13:40 PDT 2017


On Mon, Jul 24, 2017 at 12:09 PM, Linus Torvalds
<torvalds at linux-foundation.org> wrote:
>
> I think we'll need to create some test data with Dirk, but we only have
> two Suunto transmitters between us to begin with, and mine is already off
> for the recall.
>
> We do have three transmitters total for the Shearwater [..]

Bah.

It was easy to test the downloading: I just hacked up the
libdivecomputer Suunto EON Steel back-end to start generating random
pressure data for multiple cylinders.

And it turns out that we seem to handle the case of two sensors fine
these days. So I think the sidemount case should work.

If we actually have three sensors, subsurface indeed gets very
confused. The code that shows pressure sensors simply expects that
each pressure slot is consistent over the whole dive, and it does
*not* actually look at the index in the pressure slot except to say
what gas it is.

I'll fix that, since I can easily generate bogus data with many sensors.

               Linus


More information about the subsurface mailing list