[PATCH] Profile support for multiple concurrent pressure sensors

Gaetan Bisson bisson at archlinux.org
Sun Jul 30 00:41:31 PDT 2017


[2017-07-27 14:08:52 -0700] Linus Torvalds:
> This finally handles multiple cylinder pressures, both overlapping and
> consecutive, and it seems to work on the nasty cases I've thrown at it.

This commit actually breaks the profile for all my dives. :)

See the attached file "bad.jpg" for what happens with the latest git
master: some pressure lines are missing from the profile. Prior to
commit e1b880f444172a04d5dd8deda7c954fbbc697708 all was well, as can be
seen in "good.jpg".

I'm attaching a test logbook with just three dives: a one-tank dive, a
two-tank dive, and a CCR dive. All were downloaded from an OSTC3. With
the latest git master, the profile shows no pressure curve at all for
the CCR and one-tank dive, and shows only one segment for the two-tank
dive (that's the one in the jpg files attached).

(I've never been a big fan of the <event type='25' name='gaschange'/>
syntax but that's what my OSTC3/libdc give me. If that's the issue I'd
be happy to "fix" those lines in my logbook, but I haven't found how
yet...)

Cheers.

-- 
Gaetan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test.xml
Type: application/xml
Size: 371708 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170729/81d4b09f/attachment-0001.xml>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bad.jpg
Type: image/jpeg
Size: 122102 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170729/81d4b09f/attachment-0002.jpg>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: good.jpg
Type: image/jpeg
Size: 105304 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170729/81d4b09f/attachment-0003.jpg>


More information about the subsurface mailing list