Github issue 412: lbs values

[Dirk Hohndel]

I'm way behind on looking at stuff. I may find time tomorrow, definitely next week on the dive trip.

/D

⁣-- 
>From my phone​


-------- Original Message --------
From: "Lubomir I. Ivanov" <neolit123 at gmail.com>
Sent: Sat Jun 10 13:30:39 PDT 2017
To: Linus Torvalds <torvalds at linux-foundation.org>
Cc: Subsurface Mailing List <subsurface at subsurface-divelog.org>, Dirk Hohndel <dirk at hohndel.org>
Subject: Re: Github issue 412: lbs values

On 10 June 2017 at 23:13, Linus Torvalds <torvalds at linux-foundation.org> wrote:
> On Sat, Jun 10, 2017 at 12:49 PM, Lubomir I. Ivanov <neolit123 at gmail.com> wrote:
>>
>> perhaps both the lrint() calls should be removed and let QString()
>> with 'f' (0/1) handle that?
>
> Agfreed. The whole "lbs = lrint(lbs + 0.05);" thing isn't even a
> sensible thing to do in the first place, and the other version (that
> adds half a lbs) is confused too, since lrint() already rounds.
>
> So ack on your patch.
>

attached is the signed-off patch with a commit message.
maybe Dirk can confirm if we need to handle it differently.

lubomir
--
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170610/1c7e13d6/attachment-0001.html>