[PATCH] Fix buffer overrun and primary sensor id issues in Liquivision import

Miika Turkia miika.turkia at gmail.com
Sun Jun 11 16:26:14 PDT 2017

> On 12 Jun 2017, at 7.12, Dirk Hohndel <dirk at hohndel.org> wrote:
> Hi Robert,
> And welcome to the Subsurface developer team. I'm always excited when
> we get new input and new reports. My absolute favorite (of course), are
> reports that come with patches - so I already am thrilled to have you on 
> the team :-)
>> On Jun 11, 2017, at 4:05 PM, Robert Bodily <robert at bodily.com> wrote:
>> Sorry, I'm new here and not entirely sure of the proper way to do this so
>> I'm copying the contents of the patch file here and also attaching it to
>> this email.
> The included patch was mangled, but the attached one looks good.
> Miika, John, would you take a look and comment? Normally I'd prefer
> something like this in multiple patches (each fixing one issue), but
> the patch looks reasonably small, so assuming you have no issue
> with the patch's content, I'll be happy to take it as is - but given that
> I know next to nothing about the Liquivision import, I'd prefer an ACK
> or two.

I'll try to take a look after today's dives.

Would it be possible to get a sample dive with multiple sensors, either directly to me or to be included in our source tree as test data? I haven't seen any such lig so it would be interesting to see...


More information about the subsurface mailing list