[PATCH] Fix buffer overrun and primary sensor id issues in Liquivision import
miika.turkia at gmail.com
Mon Jun 12 06:44:12 PDT 2017
I clearly need some sleep, sending empty messages...
On Mon, Jun 12, 2017 at 7:12 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
> Hi Robert,
> And welcome to the Subsurface developer team. I'm always excited when
> we get new input and new reports. My absolute favorite (of course), are
> reports that come with patches - so I already am thrilled to have you on
> the team :-)
>> On Jun 11, 2017, at 4:05 PM, Robert Bodily <robert at bodily.com> wrote:
>> Sorry, I'm new here and not entirely sure of the proper way to do this so
>> I'm copying the contents of the patch file here and also attaching it to
>> this email.
> The included patch was mangled, but the attached one looks good.
> Miika, John, would you take a look and comment? Normally I'd prefer
> something like this in multiple patches (each fixing one issue), but
> the patch looks reasonably small, so assuming you have no issue
> with the patch's content, I'll be happy to take it as is - but given that
> I know next to nothing about the Liquivision import, I'd prefer an ACK
> or two.
Everything looks good to me (if you can trust someone who just showed
not to be able to use email properly:D). The only question I have is,
how will this work in case there is other than 9 additional sensors in
the configuration? Does the input data include empty values, or are
e.g. the buddy/group sensor infos missing (in which case this might
parse random data, or is this actually taken care of in the patch).
More information about the subsurface