[PATCH] MultiFilter: make sure to uncheck "Filter divelist" if the user closes

Dirk Hohndel dirk at hohndel.org
Mon Jun 12 19:28:58 PDT 2017


On Tue, Jun 13, 2017 at 01:18:57AM +0300, Lubomir I. Ivanov wrote:
> 
> I'm building against Qt 5.5.1 and there are consistent asserts

That is getting a bit old...

> when closing / clearing the filter:
> ASSERT failure in QPersistentModelIndex::~QPersistentModelIndex:
> "persistent model indexes corrupted",
> file itemmodels\qabstractitemmodel.cpp, line 557
> 
> void MultiFilterSortModel::clearFilter()
> {
> 	justCleared = true;
> 	Q_FOREACH (MultiFilterInterface *iface, models) {
> 		iface->clearFilter();
>                ^
>                possible cause
> 
> The latest official Windows binaries seem OK.

I think they are build against 5.8 right now - haven't switched them to
5.9, yet.

Change looks reasonable to me. What I don't see is why this would get an
assert.

Tomaz, any idea?

/D


More information about the subsurface mailing list