Several float to int potential rounding errors/inconsistencies

[Dirk Hohndel]

On Wed, Mar 08, 2017 at 02:42:28PM +0700, Jérémie Guichard wrote:
> 
> Unfortunately I could not enable the flag in that commit since travis seems
> to be using gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4 that do not include
> this option... Nevertheless it may be a good idea to make use of the option
> so should we:
> 1. Upgrade travis build to use more recent version of gcc and add the flag
> unconditionally?

No, we are still supporting Trusty and this would fail our Trusty builds
in general

> 2. Add the flag under a cmake gcc version condition so that people using
> more recent version of gcc in their dev env be warned about the mistakes?

Yes, that would be my preference

> 3. Since 1 could be annoying to people still using older gcc in their dev
> env, we could upgrade travis but still put the flag behind a condition like
> proposed in 2?

I don't see the value of having this in travis - unless you build tests
that rely on the output of this flag.

/D