WIP - Tabbs rework

Dirk Hohndel dirk at hohndel.org
Sun Mar 12 15:41:28 PDT 2017


Hi Tomaz,

It's great to see that you are working on things! I had assumed that I'd
have more time this weekend to work on things, but it turned out I got
side tracked with all the pull requests and with fixing the unit system
change bug in the mobile apps...

On Fri, Mar 10, 2017 at 11:53:16AM +0100, Tomaz Canabrava wrote:
> My time is crazy and I fear I'm taking too long to finish this because I
> just don't find the time to work, sorry.

I know how that feels.

> This is the current WIP, there's still a bit of things to be done, I would
> appreciate some help finishing this.

It would help if you told us what help you need.

> this is *NOT* a rework like the preferences that added a lot of code for
> little gain, this doesn't adds a lot of code (actually, almost nothing) and
> the gain is big.

And it would help to understand what that gain is.

The series doesn't apply cleanly for me because my tooling tries to fix
some of the obvious white space garbage as it applies things, and then of
course patches that contain the white space garbage no longer apply.

It would make my life so much easier if you just used Qt Creator with the
same settings as the rest of us, but I guess that ship has sailed and I
just should stop even asking for that. Which means it might be easier if
you just point me to the branch on github that I can pull from (because
then my tooling won't mess things up).

Anyway, after I applied the 42 patches things compile and I get a mostly
working UI - but again, I'm not sure what I should be looking at, what I
should be working on.

Clearly the Equipment tab and Extra Info tab are non-functional.
Statistics and Photo tab seems unchanged (or identical).
There are small functional issues with the Notes tab (specifically, the
Depth and Duration fields that should only be shown if this is a manually
entered dive are always shown), but other than that this seems reasonably
complete.

I can easily push this into a branch on github, but unless the rest of us
understand better

- what are you doing?
- why are you doing it (i.e., what's the benefit)?
- where would it make sense for us to try to help (so that we aren't
  changing code that you are working on right now)?

I'm not quite sure what to do with this.

/D



More information about the subsurface mailing list