[PATCH] subsurface-mobile: fixes to dive edit view, post most of things to QtQuickcontrols2

Marco Martin notmart at gmail.com
Fri Mar 31 05:23:21 PDT 2017


Hi all,

as promised, this patch makes the dive edits view fully functional again and 
ports most of the things to QtQuickcontrols2 (advantage is that it would look 
way more at home with android material apps

some issues:
* combobox in the edit view is still not ported, it's a bit tricky with qqc2 
comboboxes as they are not editable. however, it seemed it wasn't really 
semantically a combobox, rather a textfield that used the combo for typing 
suggestions? that could be reimplmented easily with a textfiled that has an 
internal listview for displaying suggestions
* downloadfromdivecomputer.qml is not ported, as it didn't seem to be used at 
all in the app?
* StyledTextField and subsurfacebutton components would go, making code a bit 
simpler (in qqc2 they are styled more android-like, is still possible to write 
a text field styled completely different, if needed)


screenshot: http://imgur.com/a/yX6Kb

-- 
Marco Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fully-port-dive-edit-to-Kirigami2.patch
Type: text/x-patch
Size: 16221 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170331/7218936a/attachment-0001.bin>


More information about the subsurface mailing list