[PATCH] subsurface-mobile: fixes to dive edit view, post most of things to QtQuickcontrols2

Marco Martin notmart at gmail.com
Fri Mar 31 08:43:27 PDT 2017


on my clone, now also a replacement for the combobox that does what was as far 
i understood the intention there.

On Friday 31 March 2017 15:20:26 Marco Martin wrote:
> On Friday 31 March 2017 15:05:12 Dirk Hohndel wrote:
> > Yes - that's pretty much what it is. I don't think I know how to implement
> > that. Can you point me at a starting point...
> 
> i can give it a try and update the patch
> 
> > > * downloadfromdivecomputer.qml is not ported, as it didn't seem to be
> > > used
> > > at all in the app?
> > 
> > Willem is working on implementing that, but got stalled. I'm sure that he
> > would love some pointers to get that part going.
> 
> I can port blindly that file then
> 
> > > * StyledTextField and subsurfacebutton components would go, making code
> > > a
> > > bit simpler (in qqc2 they are styled more android-like, is still
> > > possible
> > > to write a text field styled completely different, if needed)
> > 
> > I'm not quite sure what you mean by that...
> 
> I mean, as far i understood, those two classes were created to make the text
> edit and the button more android looking, but stock qtquickcontrols2 ones
> seems pretty good already, so dropping those 2 classes, simplifies things a
> bit

-- 
Marco Martin


More information about the subsurface mailing list